Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: liteprotocoltester for simulation #2813

Merged
merged 12 commits into from
Aug 21, 2024
Merged

chore: liteprotocoltester for simulation #2813

merged 12 commits into from
Aug 21, 2024

Conversation

NagyZoltanPeter
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter commented Jun 14, 2024 •
edited
Loading

Description

This PR contains changed to lite-protocol-tester for integration with waku-simulator

Changes

  • Separate docker compose file provided for waku-simulator configuration
  • More flexible configuration on startup delay and message size randomization
  • Default more publisher and 1 receiver set
  • Added connectivity diagnosis periodic logging
    • Log self connectivity
    • Refined lost and duplicate message detection and reporting.
  • Enable standalone run against any fleet
    • separate docker image is built for easy reuse.

How to test

see: README.md

@NagyZoltanPeter NagyZoltanPeter self-assigned this Jun 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2813-rln-v2

Built from fbeadba

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2813-rln-v1

Built from fbeadba

@NagyZoltanPeter NagyZoltanPeter mentioned this pull request Jun 17, 2024
Draft
@NagyZoltanPeter NagyZoltanPeter force-pushed the chore-liteprotocoltester-for-simulation branch from b4347e6 to 9657455 Compare August 2, 2024 07:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2813

Built from cf41e2d

@NagyZoltanPeter NagyZoltanPeter marked this pull request as ready for review August 7, 2024 00:56
@NagyZoltanPeter
Copy link
Contributor Author

As of now, lite-protocol-tester is ready for wider use.
It can be used on any network, either simulated or real fleet or TWN.
Message detection reporting can help find issues with easily reproducible tests.

cc: @Ivansete-status, @gabrielmer, @darshankabariya Please consider review it.

Ivansete-status
Ivansete-status approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

waku/waku_api/rest/builder.nim Show resolved Hide resolved
waku/waku_api/rest/builder.nim Show resolved Hide resolved
apps/liteprotocoltester/statistics.nim Outdated Show resolved Hide resolved
apps/liteprotocoltester/statistics.nim Show resolved Hide resolved
apps/liteprotocoltester/statistics.nim Show resolved Hide resolved
gabrielmer
gabrielmer approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much!

Just added some tiny comments

apps/liteprotocoltester/README.md Outdated Show resolved Hide resolved
apps/liteprotocoltester/filter_subscriber.nim Show resolved Hide resolved
apps/liteprotocoltester/diagnose_connections.nim Outdated Show resolved Hide resolved
@NagyZoltanPeter
Copy link
Contributor Author

Found mcos-13 test failure unrelated, timing issue.
Also not found related js-waku-test failure.

@NagyZoltanPeter NagyZoltanPeter merged commit f4fa73e into master Aug 21, 2024
9 of 11 checks passed
@NagyZoltanPeter NagyZoltanPeter deleted the chore-liteprotocoltester-for-simulation branch August 21, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

@darshankabariya darshankabariya Awaiting requested review from darshankabariya

Assignees

@NagyZoltanPeter NagyZoltanPeter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NagyZoltanPeter @gabrielmer @Ivansete-status