-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: integrate liteprotocoltester #69
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. However I would say waku-simulator
master should only support RLN I would be happy to include the new services you are integrating here, but they shall use RLN.
If there is a real need for a non RLN config, I'm open to discuss it. But we should keep the config inside the same docker-compose.
- liteprotocoltester-receivernode-13:8008 | ||
- liteprotocoltester-receivernode-14:8008 | ||
- liteprotocoltester-receivernode-15:8008 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind giving some context on what each type of node does?
how is publishernode different from lightpush-service? and filter vs receivednode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this one I could not separate hence including foreign services here.
Mind that my setup is running in a separate compose which is interconnected with simulator via the docker network it defines.
But to see my services on the board I needed to add them here.
In my setup I have n-number of lightpush client connects to a lightpush-service node and a filter client that is connected with a separate filter-service node... where service nodes are connected to waku-simulator relay network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here: waku-org/nwaku#2813
The only reason to test it without RLN is to find bottlenecks maybe helpful for Status reliability.
For now for me/us it is clearly enough to have this PR opened and living in this separate branch. That's enough for sharing among us. |
This is a WIP draft PR to demonstrate integration of nwaku/lite-protocol-tester with waku-simulator!
Changes made within:
Please note for first time we will use exact this branch to test co-op between the two projects.
If you have time to review, I would appreciate any comment and ideas!!!