fix: revert "chore: adding observers for message logging (#2800)" #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b522865.
gabrielmer
requested review from
darshankabariya,
NagyZoltanPeter and
Ivansete-status
|
You can find the image built from this PR at Built from 989d687 |
|
You can find the image built from this PR at Built from 989d687 |
Ivansete-status
approved these changes
Jun 17, 2024
gabrielmer
changed the title
gabrielmer
changed the title
NagyZoltanPeter
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b522865.
Description
The approach of using observers for logging seems to be extremely inefficient, as observers are triggered before checking whether we have received a message or not. This implies that they get triggered for repeated messages.
On the other hand, increasing the metrics in the observer is a bug, as repeated messages would be counted.
We will need then to create special versions with extra logs for simulations in a branch separate from master.
Thanks @Ivansete-status for raising the issue!
CC @AlbertoSoutullo
Changes