fix: update peers ENRs in peer store in case they are updated

[gabrielmer]

Description

Checking if the ENR of an incoming peer is the same as the one we have saved and if not, update it in the peer store.

Changes

• updating peer store for existing peers with changed ENRs

Issue

closes #2817

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2818-rln-v2

Built from 3623419

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2818-rln-v1

Built from 3623419

[richard-ramos]

PR looks good to me, but I wonder if it could be the case that when discovering you receive the same peer but with older information. Since we are not looking at the sequence number of the enr, we might end up overriding the peer information with outdated info

[richard-ramos]

Ah do note that this is a scenario that i have seen in go-waku. I do not know if such thing can happen in the nim implementation

[gabrielmer]

PR looks good to me, but I wonder if it could be the case that when discovering you receive the same peer but with older information. Since we are not looking at the sequence number of the enr, we might end up overriding the peer information with outdated info

Oh great catch! So basically before updating the ENR, we have to also check for the seqNum to be equal or greater than the one in the ENR currently saved in the peer store?

If that makes sense, will implement that fix too :)

[richard-ramos]

Oh great catch! So basically before updating the ENR, we have to also check for the seqNum to be equal or greater than the one in the ENR currently saved in the peer store?

Yes, that's what we do in go-waku! we check if the sequence number is greater to update the peer info!

[gabrielmer]

Yes, that's what we do in go-waku! we check if the sequence number is greater to update the peer info!

Done! Updated the PR, lmk in case there's something wrong with the fix.

Thanks so much!

[Ivansete-status]

LGTM! Thanks! 💯