chore: stop connecting to out peers until target is reached

[gabrielmer]

Description

We're currently attempting establish more out connections than our target. We are trying to connect 10 peers at a time, and we still dial 10 even if our target is less than 10.

When investigating #2780, I noticed that the issue started right after we tried to connect to more nodes than we could.

Making a small fix so we stick more precisely to our targets.

Changes

• only dial to the peers necessary to reach outRelayPeersTarget

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2823-rln-v2

Built from 9a53969

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2823-rln-v1

Built from 9a53969

[Ivansete-status]

Thanks for that @gabrielmer !
However, there might be something that I don't get 100% because I was assuming that we already achieve that goal from the following line:

nwaku/waku/node/peer_manager/peer_manager.nim

Line 732 in 93e9ba2

let numPeersToConnect = min(numPendingConnReqs, MaxParallelDials)

[gabrielmer]

Thanks for that @gabrielmer ! However, there might be something that I don't get 100% because I was assuming that we already achieve that goal from the following line:

nwaku/waku/node/peer_manager/peer_manager.nim

Line 732 in 93e9ba2

let numPeersToConnect = min(numPendingConnReqs, MaxParallelDials)

So before the fix that I added, numPendingConnReqs is initialized to outsideBackoffPeers.len, which is all the peers that we have saved and can connect to. But this number does not take into account our target, so if we have more possible peers than our target, we can currently overshoot.

That's why I'm fixing numPendingConnReqs to match exactly whatever is left for our target.

[Ivansete-status]

LGTM! Thanks for the clarification! 💯 🥳

Thanks to this enhancement, I understand that the precondition controlled in the next point:

nwaku/waku/node/peer_manager/peer_manager.nim

Line 724 in 317c83d

if outRelayPeers.len >= pm.outRelayPeersTarget:

...still remains at the end of the connectToRelayPeers proc. In other words, we make sure that the this condition is met: outRelayPeers.len < pm.outRelayPeersTarget

Great catch 🙌 !

[gabrielmer]

Thanks to this enhancement, I understand that the precondition controlled in the next point:

nwaku/waku/node/peer_manager/peer_manager.nim

Line 724 in 317c83d

if outRelayPeers.len >= pm.outRelayPeersTarget:

...still remains at the end of the connectToRelayPeers proc. In other words, we make sure that the this condition is met: outRelayPeers.len < pm.outRelayPeersTarget

Exactly! This was still controlled but it wasn't precise, we would overshoot most of the times and could dial up to 9 more peers than the target

[NagyZoltanPeter]

Yes, it looks ok.