chore: better descriptive log #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 4ee6e50 |
|
You can find the image built from this PR at Built from 4ee6e50 |
darshankabariya
changed the title
|
You can find the image built from this PR at Built from 30c0819 |
darshankabariya
requested review from
Ivansete-status,
gabrielmer and
NagyZoltanPeter
Ivansete-status
approved these changes
Jun 20, 2024
waku/factory/node_factory.nim
Outdated
| @@ -148,6 +148,8 @@ proc setupProtocols( | |||
| conf.contentTopics.mapIt(node.wakuSharding.getShard(it).expect("Valid Shard")) | |||
| let pubsubTopics = conf.pubsubTopics & shards | |||
|
|
|||
| debug "Shards created for content filter", shards = shards | |||
There was a problem hiding this comment.
Suggestion to give a bit more detail when we have contentTopics as a parameter
Suggested change
| debug "Shards created for content filter", shards = shards | |
| if conf.contentTopics.len > 0: | |
| debug "Shards created from content topics", contentTopics = conf.contentTopics, shards = shards |
darshankabariya
force-pushed
the
debug_issue
branch
from
1ff33a2
to
bdbf463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was confusion in distinguishing between the content and the pubsub topic in logs. Now, the logs are more descriptive, clearly specifying which content-topic pair has the issue.