Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simple PR from release/v0.29 to fix the tag history #2827

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Jun 20, 2024

In this PR, I need to use the following merging option so that the master branch is written correctly:
image

This PR is a repetition of the following one: #2802, where I didn't use the correct merge option.

@Ivansete-status Ivansete-status marked this pull request as ready for review June 20, 2024 08:30
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2827-rln-v1

Built from 8ac2a34

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2827-rln-v2

Built from 8ac2a34

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still LGTM!!!! :-)

@Ivansete-status Ivansete-status merged commit a6ff976 into master Jun 20, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants