Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improving logging under debugDiscv5 flag #2899

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

gabrielmer
Copy link
Contributor

Description

Small PR improving logging when using the debugDiscv5 flag

Thanks @AlbertoSoutullo for noticing 🤩

Copy link

github-actions bot commented Jul 12, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2899

Built from 4e027b9

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯
Just a minor suggestion to keep the log lines shorter

waku/node/peer_manager/peer_manager.nim Outdated Show resolved Hide resolved
@gabrielmer gabrielmer force-pushed the chore-improving-discv5-logging branch from c64fed2 to 4c04437 Compare July 15, 2024 06:56
@gabrielmer gabrielmer merged commit 8578fb0 into master Jul 15, 2024
8 of 10 checks passed
@gabrielmer gabrielmer deleted the chore-improving-discv5-logging branch July 15, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants