Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: archive legacy run report metrics every 30 minutes instead of 1 #2903

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Ivansete-status
Copy link
Collaborator

Description

Simple PR to reduce the stress on the database and only count the number of messages every 30 minutes instead of each minute.

@Ivansete-status Ivansete-status self-assigned this Jul 14, 2024
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2903

Built from bcc0204

@Ivansete-status Ivansete-status marked this pull request as ready for review July 15, 2024 11:15
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok for long checks, but will it give enough resolution for short term testings?

@Ivansete-status
Copy link
Collaborator Author

It is ok for long checks, but will it give enough resolution for short term testings?

You are right that it seems too low rate for short tests. Nevertheless, the underlying query is too much resource-consuming

@Ivansete-status Ivansete-status merged commit b71ab28 into master Jul 15, 2024
9 of 11 checks passed
@Ivansete-status Ivansete-status deleted the extend-metrics-report-interval branch July 15, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants