chore: return all connected peers from REST API

[weboko]

Description

Currently GET /admin/v1/peers has additional logic to build a list of peers service node is connected to.
It does go through each group of protocols and builds a list:

nwaku/waku/waku_api/rest/admin/handlers.nim

Line 43 in 6d385ce

if not node.wakuRelay.isNil():

We can directly return list of connected peers as it more aligned with description of the endpoint:

Retrieve information about connected peers.

[NagyZoltanPeter]

Sorry, but it is not working this way. We have a API response structure we must confirm with. So we return peers with their supported protocols.
This issue here - I think - that we won't return peers with protocol if the same protocol we don't support. (we = the node queried by GET /admin/peers). I think we should return all peers are connected and list all the protocols they support.

Also to mention this API endpoint has got no influence on how real connections are made, it is simply just a view of the current peer store.
Also there is the POST /admin/peers where we can inject new relay peers for the node.

[NagyZoltanPeter]

@weboko : Please check, I updated your PR with the thought functional change.
My question if this is enough for a client (admin) purposes. Do we really need all peers with all protocols?
cc: @jm-clius

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2923

Built from d763cd5

[gabrielmer]

LGTM, thank you!

Maybe we should add a test case for this?

[NagyZoltanPeter]

LGTM, thank you!

Maybe we should add a test case for this?

Yepp, done!