Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update and shift unittest #2934

Merged
merged 5 commits into from
Jul 26, 2024
Merged

fix: update and shift unittest #2934

merged 5 commits into from
Jul 26, 2024

Conversation

darshankabariya
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2934

Built from cc02fbc

@darshankabariya
Copy link
Contributor Author

Hi @rymnc,
In my previous PR, I missed your last comment. I've now addressed it and find better place for the test.

rymnc
rymnc approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit, will need to change the error returned :)

tests/node/test_wakunode_relay_rln.nim Outdated Show resolved Hide resolved
rymnc
rymnc reviewed Jul 26, 2024
View reviewed changes
tests/node/test_wakunode_relay_rln.nim
@@ -162,7 +162,7 @@ suite "Waku RlnRelay - End to End":
await node.mountRlnRelay(wakuRlnConfig)
except CatchableError as e:
check e.msg ==
"failed to mount WakuRlnRelay: rln-relay-user-message-limit can't be exceed then MAX_MESSAGE_LIMIT set by rln contract"
"failed to mount WakuRlnRelay: rln-relay-user-message-limit can't exceed the MAX_MESSAGE_LIMIT in the rln contract"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also have to change the error returned in the actual code too

Ivansete-status
Ivansete-status approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! LGTM as long as all comments are addressed 🥳

@darshankabariya darshankabariya merged commit 08973ad into master Jul 26, 2024
10 of 11 checks passed
@darshankabariya darshankabariya deleted the unittest branch July 26, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

@Ivansete-status Ivansete-status Ivansete-status approved these changes

Assignees

@darshankabariya darshankabariya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darshankabariya @rymnc @Ivansete-status