-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: waku rendezvous wrapper #2962
Conversation
You can find the image built from this PR at
Built from 61cec10 |
|
d5247ba
to
3e651ee
Compare
bffa68b
to
6014283
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing, thanks so much! 🤩
We should probably add tests though, to make sure that the procs defined in protocol.nim
work as expected
I will add some tests but nim-libp2p already tests the functionalities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! Thanks for it! 🙌
I'm adding a bunch of nitpick comments that I hope you find useful
Description
I've wrapped libp2p rendezvous protocol so that at the waku layer we can register at rdv points and also request peer records.
spec -> https://github.com/waku-org/specs/blob/master/standards/core/rendezvous.md
Changes