Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: networkmonitor compilation issue #2964

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix: networkmonitor compilation issue #2964

merged 1 commit into from
Aug 8, 2024

Conversation

Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Aug 8, 2024 •
edited
Loading

I other PRs we have the following error:
image

@Ivansete-status Ivansete-status marked this pull request as ready for review August 8, 2024 16:57
gabrielmer
gabrielmer approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2964

Built from 4ba5e9f

@Ivansete-status Ivansete-status merged commit ac1d9ef into master Aug 8, 2024
12 of 14 checks passed
@Ivansete-status Ivansete-status deleted the fix-compilation-issue branch August 8, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmer gabrielmer gabrielmer approved these changes

@SionoiS SionoiS Awaiting requested review from SionoiS

Assignees

@Ivansete-status Ivansete-status

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ivansete-status @gabrielmer