chore: Better timing and requestId detail for slower store db queries #2994
Conversation
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
|
You can find the image built from this PR at Built from 1b3419e |
| @@ -41,6 +41,7 @@ method getMessagesV2*( | |||
| endTime = none(Timestamp), | |||
| maxPageSize = DefaultPageSize, | |||
| ascendingOrder = true, | |||
| requestId: string, | |||
There was a problem hiding this comment.
If requestId is mandatory here, would it be better at the front of the args?
Maybe it is just my old habit, I know it works in nim though...
There was a problem hiding this comment.
If requestId is mandatory here, would it be better at the front of the args? Maybe it is just my old habit, I know it works in nim though...
Ah yes you are right! Nevertheless let me take the license to leave it as is given that we will deprecate this code soon. Thanks for the comment!
| @@ -55,6 +56,7 @@ method getMessages*( | |||
| hashes = newSeq[WakuMessageHash](0), | |||
| maxPageSize = DefaultPageSize, | |||
| ascendingOrder = true, | |||
| requestId = "", | |||
There was a problem hiding this comment.
Why isn't that mandatory to set here if it is with V2 method?
There was a problem hiding this comment.
Why isn't that mandatory to set here if it is with V2 method?
Yes in this case I set it a default value to prevent changing too many tests that we will remove shortly.
Ivansete-status
force-pushed
the
better-query-timing-insight
branch
from
004c13e
to
0274ee8
Compare
Description
Better track the
requestIdthat comes fromstorerequests to lower layers (archive/database) so that we can link requests with slow queriesChanges
requestIdvalue from store layer to the database layer.pgasyncpool.nim: Print information for queries slower than 2 seconds.client.nim: allow sending customrequestId.requestedvs the sentrequestIdand they failed because we are adding therequestIdfield in theArchiveQueryobject.