Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Switch libnegentropy library build from shared to static linkage #3041

Merged
merged 3 commits into from
Sep 18, 2024
Merged

chore: Switch libnegentropy library build from shared to static linkage #3041

merged 3 commits into from
Sep 18, 2024

Conversation

NagyZoltanPeter
Copy link
Contributor

Description

Due to various link issues with libnegentropy build as shared object, this PR is an experimental/proposal to switch to static linkage.

Changes

@NagyZoltanPeter NagyZoltanPeter self-assigned this Sep 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3041

Built from 5100fe9

chaitanyaprem
chaitanyaprem approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, using this branch i was able to build and run docker image in my orangepi ubuntu which was failing before.

Ivansete-status
Ivansete-status approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

@NagyZoltanPeter NagyZoltanPeter marked this pull request as ready for review September 18, 2024 07:50
jm-clius
jm-clius approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my side.

SionoiS
SionoiS approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@NagyZoltanPeter NagyZoltanPeter merged commit 83f25c3 into master Sep 18, 2024
9 of 11 checks passed
@NagyZoltanPeter NagyZoltanPeter deleted the chore-static-link-negentropy branch September 18, 2024 12:34
@NagyZoltanPeter NagyZoltanPeter mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SionoiS SionoiS SionoiS approved these changes

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@jm-clius jm-clius jm-clius approved these changes

@Ivansete-status Ivansete-status Ivansete-status approved these changes

Assignees

@NagyZoltanPeter NagyZoltanPeter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NagyZoltanPeter @SionoiS @chaitanyaprem @jm-clius @Ivansete-status