Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disabling metrics for libwaku #3058

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

gabrielmer
Copy link
Contributor

Description

When running a node using libwaku, we repeatedly get the following error

metrics error: New label values must be added from same thread as the metric was created from - observation dropped: libp2p_gossipsub_peers_per_topic_gossipsub collector
metrics error: New label values must be added from same thread as the metric was created from - observation dropped: libp2p_gossipsub_peers_per_topic_fanout collector.
metrics error: New label values must be added from same thread as the metric was created from - observation dropped: libp2p_gossipsub_peers_per_topic_mesh collector.

Disabling by default the metrics for libwaku until the root cause is taken care of

Changes

  • undefining the metrics compilation flag
  • modified nanosecondTime to accept the type passed when metrics are disabled
  • assigning a proc to logMetrics only when metrics are defined

Issue

#3039

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3058

Built from 517b0cf

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@gabrielmer gabrielmer merged commit b358c90 into master Sep 25, 2024
11 of 12 checks passed
@gabrielmer gabrielmer deleted the chore-disable-metrics-in-libwaku branch September 25, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants