fix: rejecting excess relay connections #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from dc78de1 |
gabrielmer
force-pushed
the
fix-relay-connection-targets
branch
from
9289a73
to
139bf9a
Compare
gabrielmer
changed the title
gabrielmer
changed the title
gabrielmer
requested review from
Ivansete-status,
SionoiS,
richard-ramos,
darshankabariya and
NagyZoltanPeter
Ivansete-status
approved these changes
Sep 27, 2024
richard-ramos
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rejecting incoming Relay connections whenever we reached our
inconnections target.Currently, we accept connections and prune the excess connections periodically. However, this approach is not working out properly, as nodes can reconnect to us right after we disconnect to them, making no difference.
This makes the node vulnerable to attacks, as other nodes can fill all our connections without leaving libp2p connections to serve non-Relay nodes.
This PR addresses the issue, disconnecting from a Relay node right after receiving their request, in case we already reached our target.
The content of this PR was actually proposed by @Ivansete-status some weeks ago :) Thanks so much!
Changes
inRelayPeersTargetoutRelayPeersTargetIssue
closes #3063