Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding error logs for failed libwaku operations #3067

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

gabrielmer
Copy link
Contributor

Description

Logging in libwaku errors of failed requests. This will help us debug more easily any issue that may be found.

On a separate PR, we will error handling from the request's sender

Changes

  • logging errors for failed operations

Issue

#3039

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3067

Built from 78092b4

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks for it! 💯

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@gabrielmer gabrielmer merged commit d8e6a5c into master Oct 1, 2024
11 of 12 checks passed
@gabrielmer gabrielmer deleted the chore-improve-error-logging-in-libwaku branch October 1, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants