chore: Update prepare_release.md to add js-waku update #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
requested review from
richard-ramos,
darshankabariya,
gabrielmer and
NagyZoltanPeter
Ivansete-status
changed the title
NagyZoltanPeter
approved these changes
Oct 22, 2024
| @@ -66,3 +66,4 @@ All items below are to be completed by the owner of the given release. | |||
| - [ ] **Post release** | |||
| - [ ] Submit a PR from the release branch to master. Important to commit the PR with "create a merge commit" option. | |||
| - [ ] Update waku-org/nwaku-compose with the new release version. | |||
| - [ ] Update version in js-waku repo. [update only this](https://github.com/waku-org/js-waku/blob/7c0ce7b2eca31cab837da0251e1e4255151be2f7/.github/workflows/ci.yml#L135) by submitting a PR. | |||
There was a problem hiding this comment.
Suggested change
| - [ ] Update version in js-waku repo. [update only this](https://github.com/waku-org/js-waku/blob/7c0ce7b2eca31cab837da0251e1e4255151be2f7/.github/workflows/ci.yml#L135) by submitting a PR. | |
| - [ ] Update version in js-waku repo (job section: `node_with_nwaku_master`). [update only this](https://github.com/waku-org/js-waku/blob/master/.github/workflows/ci.yml#L135) by submitting a PR. |
WDYT?
There was a problem hiding this comment.
Or do you think that link is more permanent than to point at master? Well in this case your version can be better.
There was a problem hiding this comment.
I think it's better to use a fixed commit as a reference, because if a line gets added to that file in master it could move the reference to an unrelated line and become confusing 😶
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.