refactor(libwaku): allow several multiaddresses for a single peer in store queries #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
requested review from
darshankabariya,
gabrielmer,
NagyZoltanPeter and
Ivansete-status
|
You can find the image built from this PR at Built from 8ededf8 |
richard-ramos
force-pushed
the
libwaku/store-query-peerAddr
branch
from
2df0455
to
43a5335
Compare
NagyZoltanPeter
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nim-libp2p should choose then which multiaddr to use when dialing the peer. This is useful since for example in status-go the storenode list contains both the multiaddress with a DNS, and also another with an IP (for the cases in which for some reason the nameserver fail to resolve the dns name).
It also fixes a parameter name in the ping requests