chore: Adjusted peer-exchange to the latest changes made due to rate limit DOS protection

[NagyZoltanPeter]

As a consequence of waku-org/nwaku#3035 and waku-org/nwaku#3028
Peer Exchange protocol specification must be changed.
In order to reflect possible error cases such as request is rejected due to rate limitation on responder side we must introduce response_status field which can hold detailed information of the processing outcome.

Status codes are also defined while response_status can contain descriptive information also.

[chaitanyaprem]

one more point to note is changes to this spec needs to be implemented in go-waku and hence need to go live together in status app and fleet nodes. Otherwise compatibility needs to be maintained so that even if we go live in fleet first, clients should not get affected.

Also note that peer-exchange service is being provided by status-desktop as well which means update of fleet and desktop instances should be planned together if possible.

So, not sure if we want to take this live as part of status fleets or only as general protoocl update. just wanted to higlight this point.

[NagyZoltanPeter]

one more point to note is changes to this spec needs to be implemented in go-waku and hence need to go live together in status app and fleet nodes. Otherwise compatibility needs to be maintained so that even if we go live in fleet first, clients should not get affected.

Also note that peer-exchange service is being provided by status-desktop as well which means update of fleet and desktop instances should be planned together if possible.

So, not sure if we want to take this live as part of status fleets or only as general protoocl update. just wanted to higlight this point.

Yes, thank you for this point. I meant this PR also to talk about it openly.
My idea was not to break existing functionality while able to add DOS protection to PeerEx.
Also in nwaku implementation I found that there are error cases handled but no answer sent back at all to requester.
This is fixed also in PR: waku-org/nwaku#3035

But in normal - previous - usage these change shall not affect clients using the old protocol.
Feel free to review nwaku pr.

[NagyZoltanPeter]

one more point to note is changes to this spec needs to be implemented in go-waku and hence need to go live together in status app and fleet nodes. Otherwise compatibility needs to be maintained so that even if we go live in fleet first, clients should not get affected.
Also note that peer-exchange service is being provided by status-desktop as well which means update of fleet and desktop instances should be planned together if possible.
So, not sure if we want to take this live as part of status fleets or only as general protoocl update. just wanted to higlight this point.

Yes, thank you for this point. I meant this PR also to talk about it openly. My idea was not to break existing functionality while able to add DOS protection to PeerEx. Also in nwaku implementation I found that there are error cases handled but no answer sent back at all to requester. This is fixed also in PR: waku-org/nwaku#3035

But in normal - previous - usage these change shall not affect clients using the old protocol. Feel free to review nwaku pr.

@chaitanyaprem: I applied the changes, please have a look.

[chaitanyaprem]

LGTM, barring minor comment.

[jm-clius]

Thanks! I have a couple of comments below, mostly minor and related to formulation. I think the most important to clarify is around field names. I think at some point the status and desc fields might have changed names from respond and response_status and this is not yet reflected in the description?

[jm-clius]

Very minor comments, but can be merged when addressed

[chaitanyaprem]

few comments otherwise looks good.