Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log, capitalize constant, simplify lambda, and add a launch config #181

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

khatchad
Copy link
Collaborator

@khatchad khatchad commented Apr 9, 2024

Trying to make #176 more readable. Thus, this PR can be merged before #176, @msridhar. Thanks.

Changes

  • Fix logs.
    Module names don't include a file extension.
  • Add launch configuration.
    To debug Maven builds remotely.
  • Capitalize constant.
  • Simplify lambda.

Module names don't include a file extension.
We have the full file path, why not use it? I see in 3cf9b35 that this was changed for `FileModule`s, but I cannot understand why.
To debug Maven builds remotely.
@khatchad khatchad changed the title contrib misc5 Miscellaneous changes Apr 9, 2024
@khatchad khatchad requested a review from msridhar April 9, 2024 18:36
@khatchad khatchad marked this pull request as ready for review April 9, 2024 18:36
@khatchad khatchad changed the title Miscellaneous changes Fix log, capitalize constant, simplify lambda, and add a launch config Apr 9, 2024
@khatchad khatchad enabled auto-merge (squash) April 9, 2024 20:02
@khatchad khatchad merged commit fc05485 into wala:master Apr 16, 2024
1 check passed
@khatchad khatchad deleted the contrib_misc5 branch April 16, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants