-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building on JDK 21, and don't crash on JDK 21 bytecodes #1339
Conversation
f14ceee
to
306baa4
Compare
Once this PR is approved, I will add the JDK 21 / ubuntu CI job as required before landing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been silently reviewing this PR's progress with each successive commit. That puts me in a position to approve this pull request now with little delay. Trust me that I have indeed looked over everything you're changing here.
Well done, @msridhar! 💪🧠 |
Thanks for the quick review, @liblit! The |
With these changes, WALA builds and runs on JDK 21, and our regression tests pass, except for the Dalvik tests. The Dalvik test issue is tracked as #1349. I think it's best to land these changes now, since they include important fixes for JDK 21 support. We can then fix Dalvik in a follow-up.
The main logic fix was to update the native models for
java.lang.Thread
to account for implementation changes there. Also there are a bunch of changes due to the deprecation of theURL(String)
constructor.