Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building on JDK 21, and don't crash on JDK 21 bytecodes #1339

Merged
merged 15 commits into from
Dec 18, 2023

Conversation

msridhar
Copy link
Member

@msridhar msridhar commented Dec 1, 2023

With these changes, WALA builds and runs on JDK 21, and our regression tests pass, except for the Dalvik tests. The Dalvik test issue is tracked as #1349. I think it's best to land these changes now, since they include important fixes for JDK 21 support. We can then fix Dalvik in a follow-up.

The main logic fix was to update the native models for java.lang.Thread to account for implementation changes there. Also there are a bunch of changes due to the deprecation of the URL(String) constructor.

Copy link

github-actions bot commented Dec 1, 2023

Test Results

   555 files  +100     555 suites  +100   3h 17m 39s ⏱️ + 42m 45s
   731 tests ±    0     714 ✔️ ±    0  17 💤 ±  0  0 ±0 
3 410 runs  +602  3 323 ✔️ +585  87 💤 +17  0 ±0 

Results for commit 22a1b6a. ± Comparison against base commit 7a13052.

♻️ This comment has been updated with latest results.

@msridhar msridhar changed the title [WIP] Support building on JDK 21, and don't crash on JDK 21 bytecodes Support building on JDK 21, and don't crash on JDK 21 bytecodes Dec 18, 2023
@msridhar msridhar marked this pull request as ready for review December 18, 2023 02:09
@msridhar msridhar requested a review from liblit December 18, 2023 02:09
@msridhar
Copy link
Member Author

Once this PR is approved, I will add the JDK 21 / ubuntu CI job as required before landing it.

Copy link
Contributor

@liblit liblit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been silently reviewing this PR's progress with each successive commit. That puts me in a position to approve this pull request now with little delay. Trust me that I have indeed looked over everything you're changing here.

@msridhar msridhar enabled auto-merge (squash) December 18, 2023 02:44
@msridhar msridhar merged commit b5f3d51 into wala:master Dec 18, 2023
7 checks passed
@liblit
Copy link
Contributor

liblit commented Dec 18, 2023

Well done, @msridhar! 💪🧠

@msridhar msridhar deleted the run-on-jdk-21 branch December 18, 2023 03:02
@msridhar
Copy link
Member Author

Thanks for the quick review, @liblit! The Thread issue was a bit nasty to track down but the rest was thankfully straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants