Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use structured KDoc comments #1344

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Use structured KDoc comments #1344

merged 1 commit into from
Dec 9, 2023

Conversation

liblit
Copy link
Contributor

@liblit liblit commented Dec 9, 2023

Also conform to KDoc conventions: initial capital letter and trailing period for the first sentence.

@liblit
Use structured KDoc comments
4172f16 
Also conform to KDoc conventions: initial capital letter and trailing
period for the first sentence.
@liblit liblit added cleanup API cleanup and refactoring low-priority A lower priority bug for WALA developers, but one for which we will happily accept a PR labels Dec 9, 2023
@liblit liblit self-assigned this Dec 9, 2023
@liblit liblit requested a review from msridhar December 9, 2023 21:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

Test Results

   455 files  ±0     455 suites  ±0   2h 34m 54s ⏱️ ±0s
   731 tests ±0     714 ✔️ ±0  17 💤 ±0  0 ❌ ±0 
2 808 runs  ±0  2 738 ✔️ ±0  70 💤 ±0  0 ❌ ±0 

Results for commit 4172f16. ± Comparison against base commit 1144a18.

msridhar
msridhar approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liblit liblit merged commit 380b3df into wala:master Dec 9, 2023
8 checks passed
@liblit liblit deleted the use-KDoc-comments branch December 9, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msridhar msridhar msridhar approved these changes

Assignees

@liblit liblit

Labels
cleanup API cleanup and refactoring low-priority A lower priority bug for WALA developers, but one for which we will happily accept a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liblit @msridhar