Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
analysisScope toJson function #1355
analysisScope toJson function #1355
Changes from 21 commits
1187f33
3a90899
6c81529
163aa8e
6f69ce9
307607a
cb5dd7b
b489343
a38c5b7
ab16227
a43b836
6d15461
e57b590
0f8f978
c237c76
fbe9c59
3cfff82
ebd73ae
89359aa
ed5500c
7036d90
9b7b7e9
a41401a
c7707eb
8b9c04d
15a4a1e
7729aa7
f777f66
efad143
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to create this temp scope just to test the exclusions. Just skip testing the exclusions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment explaining why you are stopping at 5. Also the value
5
should be stored in a local variable and then that variable should be used in multiple placesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this code would be simpler if you just got rid of the
cnt
variable and added everything. Is there any reason to add the limit?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check will not pass on other machines. You have the
stdlibs
array above. You should use the strings there (which give the full paths to the jars where the tests are running) to check that the right strings are in the JSON.