Limit right paging to text #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When paging right, it was possible to infinitely go to the right. This commit changes that so it is only possible to go right until the last visible character is out of screen.
|
Thanks Emanuel! ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The change:
When paging right, it was possible to infinitely go to the right. This changes that so it is only possible to go right until the last visible character is out of the screen. Only the lines that are currently on screen are taken into account for the limit.
I'm not sure if this change is wanted by anyone but me, but, suspiciously often, I somehow end up scrolling way past the end of the text to the right so I've decided to make a change to stop that from happening.
I figured I'd make a PR in case this behavior is something more people want, if not, feel free to close.
Also, the limit ignores whitespace to the right of the characters.
I've only tested with a few sample files, and not all options though. If needed, I can test a bit more comprehensively and make changes to the code.