This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
refactor: bet price functions #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolfix
suggested changes
Sep 30, 2021
| const one = new BigDecimal(1); | ||
| const oneToken = new BigDecimal(this.ONE); | ||
| const priceString = one.divide(input).multiply(oneToken).round(2); | ||
| const price = Number(priceString.value); |
There was a problem hiding this comment.
do not use Number. floats are banned in this library :) use BigInt everywhere and decimals for prices. to store values in database use DECIMAL type
There was a problem hiding this comment.
I removed, it is already decimal in db. thanks
| const client = await createDBTransaction(); | ||
| let results = []; | ||
| try { | ||
| for (const command of commands) { |
There was a problem hiding this comment.
I like it! should we move all function that require transaction to use this?
There was a problem hiding this comment.
yes that would remove a lot of duplicate transaction creating and error handling code
| }); | ||
|
|
||
| test('outcome prices change on buy', async () => { | ||
| const id = `test_id_${nanoid(10)}`; |
| }); | ||
|
|
||
| test('Converts price to decimal', () => { | ||
| const bet = new Bet('test-bet', 4); |
There was a problem hiding this comment.
do not use same bet id twice. you have dependency on the previous test here. the nanoid you use below is the way to go
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.