Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-context initialization #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gersak
Copy link

@gersak gersak commented Nov 21, 2024

Hi,

This pull request addresses 2 changes.

First one is support for graphql-ws protocol specification: https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.md that is supported in newer versions of GraphiQL

Second one is base-context initialisation for connection-loop. Currently in subscriptions namespace there is no other way to extend base-context and include some ws request params data into base-context that connection-loop will use to process incoming GraphQL subscription request.

Why? Authorization i.e. If access_token is sent during ws establishment and user info (roles, groups) are important for subscription execution, base-context feels like logical place to hold that information. Since it is available to all subscription resolvers. Right?

If I misunderstood current codebase i apologise and would be really grateful if u could show me workarounds.

Thanks,
Robert

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

@gersak gersak changed the title Changes to support graphql-ws spec https://github.com/enisdenjo/graph… base-context initialization Nov 21, 2024
@gersak
Copy link
Author

gersak commented Nov 25, 2024

Thanks for the assignment... Could you provide me with more info on what is expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants