Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added libtinfo dependency #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added libtinfo dependency #33

wants to merge 3 commits into from

Conversation

leetonidas
Copy link

required on aarch64 debian bookworm. While libreadline requires e.g. tputs it does not link against libtinfo itself.

Fixes #32

@leetonidas
added libtinfo dependency
81f47ed 
required on aarch64 debian bookworm. While libreadline requires e.g.
tputs it does not link against libtinfo itself.
@walterschell
Copy link
Owner

The CI for this failed on osx, can you add a check that just scopes the addition to the platform that needs it? Also what triplet/toolchain/sysroot are you using? I’d like to add a cross compile check (maybe emulated run of test suite if I can get that to work) before merging. I’ll take care of updating the ci, just need to know what your env is to match.

@leetonidas
Copy link
Author

Sure, will do. I wrote a small blog post demystifying cross compilation. It is basically that setup, just that i use bookworm instead of buster. The checks passed within the chroot.

TL/DR: debian bookworm installed via debootstrap with the libreadline-dev package installed and emulated via qemu-aarch64-static.
The triple is arm64-linux-gnu. If that does not work aarch64-linux-gnu may work.

@leetonidas
modified check for readline and tinfo
8658373 
- switched from CHECK_INCLUDE_FILE to CHECK_LIBRARY_EXISTS
	fixes detection issue of readline on archlinux due to
	missing imports (unknown type FILE)
- discovering tinfo using CHECK_LIBRARY_EXISTS
	the result is used in the discovery of readline as the same
	error as discussed in walterschell#32 prevented the
	detection of readline
@leetonidas
unset CMAKE_REQUIRED_LIBRARIES after use
dcb562f
@leetonidas
Copy link
Author

the changes are inspired by this post.

  • changed detection method for readline to CHECK_LIBRARY_EXISTS. This solves detection issues on my system as the not all types used by the readline.h header have been defined (further includes missing) - arch linux
  • added detection of tinfo via CHECK_LIBRARY_EXISTS. If it does exist it is also used in the detection of readline to prevent the same issue as Missing link library tinfo on arm64 #32

on a different note: I updated the blog post as library detection was not working. See cmake guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing link library tinfo on arm64
2 participants
@leetonidas @walterschell