Update production script #1280
Open
Update production script #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying docs with
|
| Latest commit: |
f4dc0d1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://df2b8f9a.docodile.pages.dev |
| Branch Preview URL: | https://update-production-sh.docodile.pages.dev |
- Improve the check for whether we are in Cloudflare - Determine if we are building main or a PR preview - Echo the Cloudflare variables for debugging - Only set a specific Hugo build context if we are in a PR preview - Improve how the sitemap is moved around - More code comments
mdlinville
force-pushed
the
update_production_sh
branch
from
6728df7 to
f4dc0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix for broken images in PR previews was overly broad and has resulted in incorrect domains in the English sitemap. This was because I made some incorrect assumptions about the Cloudflare environment variables. This PR aims to correct the problems introduced by that fix.
To test:
scripts/production.sh. The build output should correctly detect that we are building locally.maindeploy with this fix, I think we need to merge this PR.