feat(launch): adding agent.nodeSelector variable for agent chart
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding readme docs adding a default value in the values file
bcsherma
requested review from
gls4,
jsbroks,
nfoucha and
vanpelt
as code owners
bcsherma
requested review from
gtarpenning,
KyleGoyette,
nickpenaranda,
TimH98 and
zacharyblasczyk
as code owners
KyleGoyette
reviewed
Nov 1, 2023
| @@ -46,6 +46,7 @@ The table below describes all the available variables in the chart: | |||
| | `agent.image` | string | No | `wandb/launch-agent-dev:latest` | Container image for the agent. | | |||
| | `agent.imagePullPolicy` | string | No | `Always` | Pull policy for the agent container image. | | |||
| | `agent.resources` | object | No | Limit to 1 CPU, 1Gi RAM | Pod spec resources block for the agent. | | |||
| | `agent.nodeSelector` | object | No | `{}` | Node selector for the agent pod. | | |||
There was a problem hiding this comment.
Does leaving this blank break anything?
KyleGoyette
reviewed
Nov 1, 2023
charts/launch-agent/Chart.yaml
Outdated
| @@ -3,7 +3,7 @@ name: launch-agent | |||
| icon: https://em-content.zobj.net/thumbs/240/apple/354/rocket_1f680.png | |||
| description: A Helm chart for running the W&B Launch Agent in Kubernetes | |||
| type: application | |||
| version: 0.11.0 | |||
| version: 0.12.0 | |||
There was a problem hiding this comment.
What are the rules for minor vs patch update here?
There was a problem hiding this comment.
arbitrary. I'm actually going to do this as a patch
KyleGoyette
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a variable for the agent pod's
nodeSelectorin the values file for the agent chart.