Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support onprem storage provider #43

Closed
wants to merge 5 commits into from
Closed

feat: Add support onprem storage provider #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c98745
feat: Add support onprem storage provider
flamarion Nov 10, 2023
29e5748
Fix weave mount mode based on provider
flamarion Nov 10, 2023
c8a3ba2
Added on-prem example
flamarion Nov 10, 2023
ad92607
Bump chart version
flamarion Nov 10, 2023
cd3e32c
Fix the logic
flamarion Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/operator-wandb/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: operator-wandb
description: A Helm chart for deploying W&B to Kubernetes
type: application
version: 0.10.25
version: 0.10.26
appVersion: 1.0.0
icon: https://wandb.ai/logo.svg

Expand Down
9 changes: 6 additions & 3 deletions charts/operator-wandb/charts/weave/templates/pvc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,19 @@ metadata:
spec:
accessModes:
- {{ .Values.persistence.accessMode | quote }}
{{- if eq .Values.persistence.provider "" }}
{{- if or (eq .Values.persistence.provider "") (eq .Values.persistence.provider "onprem") }}
{{ include "wandb.storageClass" . | nindent 4 }}
{{- else }}
storageClassName: {{ template "weave.fullname" . }}-cache-{{ .Values.persistence.provider }}
{{- end }}
{{- if eq .Values.persistence.enabled "onprem" }}
volumeMode: Filesystem
{{- end }}
resources:
requests:
storage: {{ .Values.persistence.size | quote }}
---
{{- if ne .Values.persistence.provider "" }}
{{- if or (ne .Values.persistence.provider "") (eq .Values.persistence.provider "onprem") }}
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
Expand Down Expand Up @@ -53,4 +56,4 @@ mountOptions:
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
{{- end }}
{{- end }}
{{- end }}
54 changes: 54 additions & 0 deletions charts/operator-wandb/examples/on-prem/wandb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
apiVersion: apps.wandb.com/v1
kind: WeightsAndBiases
metadata:
labels:
app.kubernetes.io/name: weightsandbiases
app.kubernetes.io/instance: wandb
wandb.ai/console-default: "true"
name: wandb
namespace: default
spec:
values:
global:
host: "http://wandb.lab.local"
license: "your-license-key"
mysql:
host: "mysql.lab.local"
port: 3306
database: "wandb"
user: "wandb"
password: "password"
bucket:
provider: "s3"
name: "minio.lab.local:9000"
path: "wandb"
region: "eu-central-1"
kmsKey:
secretKey: "your-secret-key"
accessKey: "your-access-key"
mysql:
install: false
app:
install: true
image:
repository: "wandb/local"
tag: 0.45.0
extraEnv:
SUPPORTED_FILE_STORES: ""
ingress:
annotations:
# This configuration is based on Nginnx Ingress Controller
nginx.ingress.kubernetes.io/proxy-body-size: "64m"
class: "nginx"
otel:
install: true
parquet:
install: true
weave:
provider: "onprem"
persistence:
accessMode: "ReadWriteOnce"
redis:
install: true
prometheus:
install: true