chore: dont create managed cert in charts for google #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityachoudhari26
requested review from
gls4,
jsbroks,
nfoucha and
vanpelt
as code owners
adityachoudhari26
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
adityachoudhari26
changed the title
jsbroks
approved these changes
Mar 1, 2024
| - {{ replace "https://" "" (replace "http://" "" .Values.global.host) }} | ||
| {{- else }} | ||
| --- | ||
| {{- if ne .Values.ingress.issuer.provider "google" }} |
There was a problem hiding this comment.
ne .Values.ingress.issuer.provider "google" we can remove all these checks. If issuer is set to create, that use the logic, we don't need to check which type of provider is being set
adityachoudhari26
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
jsbroks
approved these changes
Mar 1, 2024
adityachoudhari26
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.