Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add nameOverride to ingress #87

Merged
merged 6 commits into from
Mar 6, 2024
Merged

chore: Add nameOverride to ingress #87

merged 6 commits into from
Mar 6, 2024

Conversation

adityachoudhari26
Copy link
Member

No description provided.

jsbroks
jsbroks requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@jsbroks jsbroks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helm automically handles namespace

@nfoucha
Copy link
Contributor

nfoucha commented Mar 6, 2024

helm automically handles namespace

Not what is trying to be solved with this PR. That said, we should consider using a different key than namespace because of the relation to helm/k8s "namespace". A customer looking at that value is going to be confused.

nfoucha
nfoucha reviewed Mar 6, 2024
View reviewed changes
charts/operator-wandb/templates/ingress.yaml Outdated
@@ -24,7 +24,7 @@ spec:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: {{ .Release.Name }}
name: {{ default .Release.Name .Values.ingress.name }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The common pattern here is to use nameOverride

@adityachoudhari26 adityachoudhari26 changed the title init chore(operator-wandb): Add nameOverride to ingress Mar 6, 2024
@adityachoudhari26 adityachoudhari26 changed the title chore(operator-wandb): Add nameOverride to ingress chore: Add nameOverride to ingress Mar 6, 2024
@adityachoudhari26 adityachoudhari26 merged commit e7b349b into main Mar 6, 2024
1 check passed
@adityachoudhari26 adityachoudhari26 deleted the achoudhari/pass-namespace-to-ingress branch March 6, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsbroks jsbroks jsbroks approved these changes

@nfoucha nfoucha nfoucha approved these changes

@gls4 gls4 Awaiting requested review from gls4

@vanpelt vanpelt Awaiting requested review from vanpelt vanpelt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityachoudhari26 @nfoucha @jsbroks