Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sweeps): optuna supports multi-objective optimization #28

Merged
merged 19 commits into from
Aug 16, 2023

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Jun 26, 2023

@gtarpenning gtarpenning marked this pull request as ready for review July 5, 2023 17:32
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more questions

if not config.get("sweep_args", {}).get("sweep_id"):
# not a sweep, just finish the run and return
if not args or not args.get("sweep_id"):
# when the config has no sweep args, this is being run directly from CLI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the user is running the wandb launch -j <job> here? Is this specifically done to create the job?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now this would be triggered by running python optuna_scheduler.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a user would do that to create the job. Sg

" does not match number of metrics defined "
f"({self._metric_defs})"
f"({self._metric_defs}). Specify metrics for optimization"
" in the scheduler.settings.metrics portion of the sweep config"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would a user have done to create this case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure its possible, i included this error message in case. If we had a testing suite.... I'll play around with it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg

Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@gtarpenning gtarpenning merged commit b8cdabb into main Aug 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants