Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Parameterize number of kubernetes nodes #138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Parameterize number of kubernetes nodes #138

wants to merge 2 commits into from

Conversation

yogeshg
Copy link
Contributor

@yogeshg yogeshg commented Sep 8, 2023 •
edited
Loading

tested by

  • setting desired+max capacity to current value
  • unsetting desired+max capacity
    This confirms that this change is backwards compatible.

@yogeshg yogeshg marked this pull request as ready for review September 8, 2023 21:28
@yogeshg yogeshg requested a review from gls4 as a code owner September 8, 2023 21:28
@yogeshg yogeshg requested review from a team, vanpelt and jsbroks September 8, 2023 21:28
gls4
gls4 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@gls4 gls4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure we test locally and then qa!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gls4 gls4 gls4 approved these changes

@vanpelt vanpelt vanpelt approved these changes

@jsbroks jsbroks Awaiting requested review from jsbroks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yogeshg @vanpelt @gls4