Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support license as a secretKeyRef #100

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ resources that lack official modules.
| <a name="input_kubernetes_instance_type"></a> [kubernetes\_instance\_type](#input\_kubernetes\_instance\_type) | Use for the Kubernetes cluster. | `string` | `"Standard_D4a_v4"` | no |
| <a name="input_kubernetes_node_count"></a> [kubernetes\_node\_count](#input\_kubernetes\_node\_count) | n/a | `number` | `2` | no |
| <a name="input_license"></a> [license](#input\_license) | Your wandb/local license | `string` | n/a | yes |
| <a name="input_license_secret_key_name"></a> [license\_secret\_key\_name](#input\_license\_secret\_key\_name) | Wandb licence secret key name | `string` | `""` | no |
| <a name="input_license_secret_name"></a> [license\_secret\_name](#input\_license\_secret\_name) | Wandb licence secret name | `string` | `""` | no |
| <a name="input_location"></a> [location](#input\_location) | n/a | `string` | n/a | yes |
| <a name="input_namespace"></a> [namespace](#input\_namespace) | String used for prefix resources. | `string` | n/a | yes |
| <a name="input_node_max_pods"></a> [node\_max\_pods](#input\_node\_max\_pods) | Maximum number of pods per node | `number` | `30` | no |
Expand Down
10 changes: 7 additions & 3 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,14 @@ module "wandb" {
spec = {
values = {
global = {
host = local.url
license = var.license
host = local.url
license = var.license
licenseSecret = {
name = var.license_secret_name, ## this will support wandb-operator chart version 0.17.9
key = var.license_secret_key_name
}
cloudProvider = "azure"
bucket = local.bucket_config == null ? {
bucket = local.bucket_config == null ? {
provider = "az"
name = module.storage[0].account.name
path = "${module.storage[0].container.name}/${var.bucket_path}"
Expand Down
12 changes: 12 additions & 0 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -308,3 +308,15 @@ variable "clickhouse_region" {
description = "ClickHouse region (eastus2, westus3, etc)."
default = ""
}

variable "license_secret_name" {
type = string
description = "Wandb licence secret name"
default = ""
}

variable "license_secret_key_name" {
type = string
description = "Wandb licence secret key name"
default = ""
}