Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Bump helm-wandb vers to v2.0.0, requires TF > 1.9 #114

Merged
merged 4 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ audit logging and single sign-on.
This module is intended to run in an Azure account with minimal
preparation, however it does have the following pre-requisites:

### Terraform version >= 1
### Terraform version >= 1.9

### Credentials / Permissions

Expand Down Expand Up @@ -48,7 +48,7 @@ resources that lack official modules.

| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | ~> 1.0 |
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | ~> 1.9 |
| <a name="requirement_azapi"></a> [azapi](#requirement\_azapi) | ~> 1.0 |
| <a name="requirement_azurerm"></a> [azurerm](#requirement\_azurerm) | ~> 3.17 |
| <a name="requirement_helm"></a> [helm](#requirement\_helm) | ~> 2.6 |
Expand Down Expand Up @@ -77,7 +77,7 @@ resources that lack official modules.
| <a name="module_redis"></a> [redis](#module\_redis) | ./modules/redis | n/a |
| <a name="module_storage"></a> [storage](#module\_storage) | ./modules/storage | n/a |
| <a name="module_vault"></a> [vault](#module\_vault) | ./modules/vault | n/a |
| <a name="module_wandb"></a> [wandb](#module\_wandb) | wandb/wandb/helm | 1.2.0 |
| <a name="module_wandb"></a> [wandb](#module\_wandb) | wandb/wandb/helm | 2.0.0 |

## Resources

Expand Down Expand Up @@ -109,6 +109,7 @@ resources that lack official modules.
| <a name="input_disable_storage_vault_key_id"></a> [disable\_storage\_vault\_key\_id](#input\_disable\_storage\_vault\_key\_id) | Flag to disable the `customer_managed_key` block, the properties 'encryption.identity, encryption.keyvaultproperties' cannot be updated in a single operation. | `bool` | `false` | no |
| <a name="input_domain_name"></a> [domain\_name](#input\_domain\_name) | Domain for accessing the Weights & Biases UI. | `string` | `null` | no |
| <a name="input_enable_database_vault_key"></a> [enable\_database\_vault\_key](#input\_enable\_database\_vault\_key) | Flag to enable managed key encryption for the database. Once enabled, cannot be disabled. | `bool` | `false` | no |
| <a name="input_enable_helm_release"></a> [enable\_helm\_release](#input\_enable\_helm\_release) | Enable or disable applying and releasing Helm chart | `bool` | `true` | no |
| <a name="input_enable_storage_vault_key"></a> [enable\_storage\_vault\_key](#input\_enable\_storage\_vault\_key) | Flag to enable managed key encryption for the storage account. | `bool` | `false` | no |
| <a name="input_external_bucket"></a> [external\_bucket](#input\_external\_bucket) | config an external bucket | `any` | `null` | no |
| <a name="input_kubernetes_cluster_oidc_issuer_url"></a> [kubernetes\_cluster\_oidc\_issuer\_url](#input\_kubernetes\_cluster\_oidc\_issuer\_url) | OIDC issuer URL for the Kubernetes cluster. Can be determined using `kubectl get --raw /.well-known/openid-configuration` | `string` | `""` | no |
Expand Down
2 changes: 1 addition & 1 deletion examples/custom-tf-with-existing-resources/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ module "cert_manager" {

module "wandb" {
source = "wandb/wandb/helm"
version = "1.2.0"
version = "2.0.0"

depends_on = [
data.azurerm_kubernetes_cluster.cluster,
Expand Down
2 changes: 1 addition & 1 deletion examples/custom-tf-with-vpc-sql/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ module "cert_manager" {

module "wandb" {
source = "wandb/wandb/helm"
version = "1.2.0"
version = "2.0.0"

depends_on = [
module.app_aks,
Expand Down
4 changes: 2 additions & 2 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ locals {

module "wandb" {
source = "wandb/wandb/helm"
version = "1.2.0"
version = "2.0.0"

depends_on = [
module.app_aks,
Expand All @@ -283,7 +283,7 @@ module "wandb" {
]
operator_chart_version = var.operator_chart_version
controller_image_tag = var.controller_image_tag

enable_helm_release = var.enable_helm_release

spec = {
values = {
Expand Down
6 changes: 5 additions & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ variable "controller_image_tag" {
default = "1.14.0"
}


variable "enable_helm_release" {
type = bool
default = true
description = "Enable or disable applying and releasing Helm chart"
}

##########################################
# DNS #
Expand Down
2 changes: 1 addition & 1 deletion versions.tf
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
terraform {
required_version = "~> 1.0"
required_version = "~> 1.9"
required_providers {
azurerm = {
source = "hashicorp/azurerm"
Expand Down