feat: Adding bigtable and pubsub support for GCP #176
+437
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpanzella
force-pushed
the
danielpanzella/bigtable-and-pubsub
branch
from
4486d82
to
454b376
Compare
annirudh
reviewed
Nov 18, 2024
modules/pubsub/main.tf
Outdated
| member = local.sa_member | ||
| } | ||
|
|
||
| resource "google_pubsub_topic" "run_updates_v2" { |
There was a problem hiding this comment.
You can skipt this -- it is regrettably a legacy thing that we are trying to remove.
annirudh
reviewed
Nov 18, 2024
modules/pubsub/main.tf
Outdated
| member = local.sa_member | ||
| } | ||
|
|
||
| resource "google_pubsub_subscription" "flat_run_fields_updater_v2" { |
There was a problem hiding this comment.
We'll need to have message ordering enabled for this: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/pubsub_subscription#enable_message_ordering-1
…ic to match what is used in kafka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.