Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial: Named workspace polish #30

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ngrayluna
Copy link
Contributor

@ngrayluna ngrayluna commented Jul 17, 2024

Added more context to the notebook (before I convert it to markdown). See https://wandb.atlassian.net/browse/DOCS-904

@ngrayluna ngrayluna requested a review from sephmard July 17, 2024 21:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.88%. Comparing base (d656a2a) to head (53d2345).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   70.88%   70.88%           
=======================================
  Files          16       16           
  Lines        2356     2356           
=======================================
  Hits         1670     1670           
  Misses        686      686           

@ngrayluna ngrayluna changed the title Word smithing Tutorial: Named workspace polish Jul 17, 2024
@ngrayluna
Copy link
Contributor Author

@ngrayluna To do: install pre commits and resolve broken CI builds

@sephmard
Copy link
Contributor

I don think we should include the notebook output. Its messy.

Copy link
Contributor

@sephmard sephmard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think that we should include the notebook output.

@ngrayluna ngrayluna requested a review from sephmard July 17, 2024 22:05
@sephmard
Copy link
Contributor

Please remove output before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants