Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): adapt paginators for automations and integrations #9194

Open
wants to merge 1 commit into
base: tonyyli/refactor-paginator-protocol
Choose a base branch
from
Open

feat(sdk): adapt paginators for automations and integrations #9194

wants to merge 1 commit into from
+293 −0

Conversation

tonyyli-wandb
Copy link
Contributor

@tonyyli-wandb tonyyli-wandb commented Jan 7, 2025 •
edited
Loading

Description

Adapts existing Paginator classes to accommodate Automations (Triggers) and Integrations (i.e. SlackIntegrations and WebhookIntegrations).

  • I updated CHANGELOG.unreleased.md, or it's not applicable

Testing

How was this PR tested?

This was referenced Jan 7, 2025
Open
Open
Open
Closed
@tonyyli-wandb Graphite App
Copy link
Contributor Author

tonyyli-wandb commented Jan 7, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tonyyli-wandb tonyyli-wandb mentioned this pull request Jan 7, 2025
Merged
1 task
@tonyyli-wandb tonyyli-wandb marked this pull request as ready for review January 7, 2025 01:18
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from 99c3abe to fada65c Compare January 7, 2025 01:21
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-public-submodules branch from 95571be to adbb627 Compare January 7, 2025 01:25
@tonyyli-wandb tonyyli-wandb requested a review from a team as a code owner January 7, 2025 01:25
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from fada65c to b8038ef Compare January 7, 2025 01:25
@tonyyli-wandb tonyyli-wandb requested a review from a team January 7, 2025 01:40
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-public-submodules branch from adbb627 to ec28300 Compare January 7, 2025 01:49
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from b8038ef to 1b75570 Compare January 7, 2025 01:50
@tonyyli-wandb tonyyli-wandb mentioned this pull request Jan 7, 2025
Open
1 task
kptkin
kptkin reviewed Jan 7, 2025
View reviewed changes
wandb/apis/paginator.py Outdated Show resolved Hide resolved
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-public-submodules branch from ec28300 to 5dc5a78 Compare January 7, 2025 20:07
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from 1b75570 to b45f5ee Compare January 7, 2025 20:07
@tonyyli-wandb tonyyli-wandb changed the base branch from tonyyli/automations-public-submodules to tonyyli/refactor-paginator-protocol January 7, 2025 20:08
@tonyyli-wandb tonyyli-wandb mentioned this pull request Jan 7, 2025
Open
1 task
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from b45f5ee to 1d26a48 Compare January 7, 2025 20:20
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 4676564 to e9ca1b8 Compare January 7, 2025 22:03
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from 1d26a48 to 8cbef37 Compare January 7, 2025 22:04
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from e9ca1b8 to 20b9046 Compare January 8, 2025 03:19
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from 8cbef37 to f24164f Compare January 8, 2025 03:19
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 20b9046 to 8c5c4d0 Compare January 8, 2025 08:35
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from f24164f to b58b2d4 Compare January 8, 2025 08:35
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 8c5c4d0 to 5acc68e Compare January 8, 2025 19:54
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from b58b2d4 to 9e8b6cb Compare January 8, 2025 19:54
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 035e1b0 to d38c5ab Compare January 9, 2025 00:38
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from 2da7b4f to f0c9f65 Compare January 9, 2025 00:38
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from d38c5ab to b166f30 Compare January 9, 2025 23:22
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch 2 times, most recently from 6e394c7 to 1c78ee8 Compare January 10, 2025 00:21
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from b166f30 to 729e276 Compare January 10, 2025 03:35
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from 1c78ee8 to f8b281e Compare January 10, 2025 03:36
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 729e276 to c634992 Compare January 10, 2025 19:31
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from f8b281e to 8dec76b Compare January 10, 2025 19:31
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from c634992 to 5094c6e Compare January 10, 2025 20:00
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from 8dec76b to b30d481 Compare January 10, 2025 20:00
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 5094c6e to 9a769d0 Compare January 10, 2025 20:30
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from b30d481 to fd66ba3 Compare January 10, 2025 20:31
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 9a769d0 to 54004af Compare January 10, 2025 20:33
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from fd66ba3 to 0bbad71 Compare January 10, 2025 20:33
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 54004af to bd02df4 Compare January 10, 2025 21:02
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from 0bbad71 to 1e15cde Compare January 10, 2025 21:02
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from bd02df4 to 189ecfa Compare January 10, 2025 21:05
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from 1e15cde to 6a3712b Compare January 10, 2025 21:05
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 189ecfa to 629cfdb Compare January 11, 2025 02:46
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch 2 times, most recently from 1258d4a to 677351e Compare January 11, 2025 02:59
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 7f41a90 to 436be53 Compare January 11, 2025 04:40
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from 677351e to 016db81 Compare January 11, 2025 04:40
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 436be53 to 1f73345 Compare January 11, 2025 05:07
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from 016db81 to c595872 Compare January 11, 2025 05:07
@tonyyli-wandb tonyyli-wandb mentioned this pull request Jan 11, 2025
Open
1 task
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/refactor-paginator-protocol branch from 1f73345 to 66079c8 Compare January 12, 2025 00:52
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-paginator-types branch from c595872 to 437059f Compare January 12, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kptkin kptkin kptkin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyyli-wandb @kptkin