feat(weave): human feedback sidebar for structured call labeling #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=0037a45c876e0a5e1b55f3afeecd25c1f9bc9dfa |
tssweeney
reviewed
Nov 18, 2024
...src/components/PagePanelComponents/Home/Browse3/feedback/HumanFeedback/humanFeedbackTypes.ts
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
...js/src/components/PagePanelComponents/Home/Browse3/feedback/HumanFeedback/tsHumanFeedback.ts
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
...js/src/components/PagePanelComponents/Home/Browse3/feedback/HumanFeedback/tsHumanFeedback.ts
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
| @@ -18,7 +18,7 @@ class AnnotationSpec(base_object_def.BaseObject): | |||
| # Boolean feedback | |||
| {"type": "boolean"}, | |||
| # Categorical feedback | |||
| {"type": "categorical", "options": ["option1", "option2"]}, | |||
| {"type": "array", "options": ["option1", "option2"]}, | |||
There was a problem hiding this comment.
this does not seem correct. Categorical should be something like
{
"type": "string",
"enum": ["one", "two", "three"]
}
There was a problem hiding this comment.
options is not a json schema key word
tssweeney
reviewed
Nov 18, 2024
...ts/PagePanelComponents/Home/Browse3/pages/wfReactInterface/generatedBaseObjectClasses.zod.ts
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/common/SplitPanelLeft.tsx
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/ObjectVersionPage.tsx
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/TabEditAnnotationSpec.tsx
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/CallPage.tsx
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
...omponents/PagePanelComponents/Home/Browse3/feedback/HumanFeedback/ToggleColumnVisibility.tsx
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
...s/src/components/PagePanelComponents/Home/Browse3/feedback/HumanFeedback/FeedbackSidebar.tsx
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
| props.callRef, | ||
| query.refetch | ||
| ); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
i think you want to at least include props.callRef
tssweeney
reviewed
Nov 18, 2024
| focused={focused} | ||
| /> | ||
| ); | ||
| case 'array': |
There was a problem hiding this comment.
I am pretty sure this is not correct (see other comments)
tssweeney
reviewed
Nov 18, 2024
...-js/src/components/PagePanelComponents/Home/Browse3/feedback/HumanFeedback/HumanFeedback.tsx
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
...-js/src/components/PagePanelComponents/Home/Browse3/feedback/HumanFeedback/HumanFeedback.tsx
Outdated
Show resolved
Hide resolved
tssweeney
approved these changes
Nov 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WB-21664
WB-21668
This pr adds a sidebar to the calls detail page, on the right, which when configured allows users to attach specific kinds of feedback to a call. These kinds of feedback can be configured by the user, of many types.
CTA:
