chore(weave): Adds weave_call_id, and option to not track to llm completions #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=ce4959bbda8b6fc8522d7ff14484b59f7d6d396b |
tssweeney
reviewed
Nov 5, 2024
weave/trace_server/llm_completion.py
Outdated
| return tsi.CompletionsCreateRes(response=res.model_dump()) | ||
| except Exception as e: | ||
| print("error", str(e), flush=True) |
There was a problem hiding this comment.
dev tracks? Else logger.error
tssweeney
approved these changes
Nov 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Come small updates to llm_completions
drop params not necessary for litellm
option to not track call
returns weave_call_id
adds error for missing LLM api key
Testing
How was this PR tested?