Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weave_ts): Fix printed URL links #2834

Merged
merged 10 commits into from
Nov 1, 2024
Merged

fix(weave_ts): Fix printed URL links #2834

merged 10 commits into from
Nov 1, 2024

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Nov 1, 2024

Description

Resolves an issue where printed UI url links were incorrect

Testing

Manual testing

@andrewtruong andrewtruong changed the base branch from master to andrew/netrc November 1, 2024 00:18
@andrewtruong andrewtruong marked this pull request as ready for review November 1, 2024 00:18
@andrewtruong andrewtruong requested a review from a team as a code owner November 1, 2024 00:19
@andrewtruong andrewtruong changed the title chore(weave_ts): Fix printed URL links fix(weave_ts): Fix printed URL links Nov 1, 2024
@andrewtruong
Copy link
Collaborator Author

@jamie-rasmussen sorry, I accidentally merged the last PR into this.

Here are the relevant changes for this PR:
4ac9a38

Base automatically changed from andrew/netrc to master November 1, 2024 18:52
@andrewtruong andrewtruong enabled auto-merge (squash) November 1, 2024 20:06
@andrewtruong andrewtruong merged commit 5a511a1 into master Nov 1, 2024
115 checks passed
@andrewtruong andrewtruong deleted the andrew/test-login branch November 1, 2024 20:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants