test

pyproject.toml

@@ -168,6 +168,7 @@ select = [
   "TID252", # https://docs.astral.sh/ruff/rules/relative-imports/#relative-imports-tid252
   "UP006",  # https://docs.astral.sh/ruff/rules/non-pep585-annotation/
   "UP007",  # https://docs.astral.sh/ruff/rules/non-pep604-annotation/
+  "UP028",  # https://docs.astral.sh/ruff/rules/yield-in-for-loop/
 ]
 ignore = [
   # we use Google style

weave/trace_server/clickhouse_trace_server_batched.py

@@ -827,8 +827,7 @@ def table_query_stream(
             limit=req.limit,
             offset=req.offset,
         )
-        for row in rows:
-            yield row
+        yield from rows
 
     def _table_query_stream(
         self,
@@ -1721,8 +1720,7 @@ def _query_stream(
                     "summary": summary,
                 },
             )
-            for row in stream:
-                yield row
+            yield from stream
 
     def _query(
         self,

weave/trace_server/sqlite_trace_server.py

@@ -1186,8 +1186,7 @@ def table_query_stream(
         self, req: tsi.TableQueryReq
     ) -> Iterator[tsi.TableRowSchema]:
         results = self.table_query(req)
-        for row in results.rows:
-            yield row
+        yield from results.rows
 
 
 def get_type(val: Any) -> str:

weave/trace_server_bindings/remote_http_trace_server.py

@@ -446,8 +446,7 @@ def table_query_stream(
     ) -> Iterator[tsi.TableRowSchema]:
         # Need to manually iterate over this until the stram endpoint is built and shipped.
         res = self.table_query(req)
-        for row in res.rows:
-            yield row
+        yield from res.rows
 
     def table_query_stats(
         self, req: Union[tsi.TableQueryStatsReq, dict[str, Any]]