Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weave): Small-batch, on-demand LLM Judge #2902

Merged
merged 147 commits into from
Nov 19, 2024

Conversation

tssweeney
Copy link
Collaborator

@tssweeney tssweeney commented Nov 6, 2024

This PR:

  1. Makes sure that the LLM Judge tabs (on Scorer Page and Create Scorer Drawer) are only viewable by W&B Admins (this allows us to iterate before showing customers)
  2. Also adds a "Scores" tab to the calls page to show Runnable scorers directly. Similarly, this is hidden for non admins

Screenshot 2024-11-18 at 15 07 10

And non Admins:

Screenshot 2024-11-18 at 15 09 50

Screenshot 2024-11-18 at 15 09 55

@tssweeney tssweeney marked this pull request as ready for review November 18, 2024 23:37
@tssweeney tssweeney requested review from a team as code owners November 18, 2024 23:37
Copy link
Member

@gtarpenning gtarpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice


export const RUNNABLE_FEEDBACK_TYPE_PREFIX = 'wandb.runnable';

const useLatestActionDefinitionsForCall = (call: CallSchema) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make ts file?

Comment on lines +137 to +144
// Here, we hide the LLM judge option from non-admins since the
// feature is in active development. We want to be able to get
// feedback without enabling for all users.
const options = useMemo(() => {
return scorerTypeOptions.filter(
opt => showRunnableUI || opt.value !== LLM_JUDGE_VALUE
);
}, [showRunnableUI]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall I do the same for human feedback?

@tssweeney tssweeney merged commit b388ab9 into master Nov 19, 2024
113 of 115 checks passed
@tssweeney tssweeney deleted the tim/basic_batch_actions_UI branch November 19, 2024 02:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants