Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(weave): Make Dataset iterable #2928

Merged
merged 2 commits into from
Nov 7, 2024
Merged

feat(weave): Make Dataset iterable #2928

merged 2 commits into from
Nov 7, 2024

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Nov 7, 2024 •
edited
Loading

Implements iter for a dataset.

Now you can do:

ds = Dataset(...)

for row in ds:
    ...

@andrewtruong andrewtruong marked this pull request as ready for review November 7, 2024 17:21
@andrewtruong andrewtruong requested a review from a team as a code owner November 7, 2024 17:21
@circle-job-mirror
Copy link

circle-job-mirror bot commented Nov 7, 2024 •
edited
Loading

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=fcaf6d7ffd1a281b3c073bc5248cbddca607e86e

@circle-job-mirror
Copy link

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=10bf2f98687ad47bcc5f67b117dd58b0efbada97

@andrewtruong andrewtruong enabled auto-merge (squash) November 7, 2024 17:28
@andrewtruong andrewtruong merged commit dd1c6ea into master Nov 7, 2024
115 checks passed
@andrewtruong andrewtruong deleted the andrew/dataset-iter branch November 7, 2024 17:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tssweeney tssweeney tssweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewtruong @tssweeney