Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): fix images damaged by exif stripping #2930

Merged
merged 3 commits into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified docs/docs/guides/core-types/imgs/audio-trace.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/core-types/imgs/cat-pumpkin-trace.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/anthropic_model.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/anthropic_ops.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/anthropic_tool.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/anthropic_trace.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/cerebras_calls.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/cerebras_model.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/cohere_model.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/cohere_ops.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/cohere_trace.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/dspy/dspy_trace.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/dspy/dspy_with_weave_op.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/groq/groq_weave_model.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/groq/groq_weave_tracing.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/docs/guides/integrations/imgs/langchain_eval.png
Binary file modified docs/docs/guides/integrations/imgs/langchain_model.png
Binary file modified docs/docs/guides/integrations/imgs/langchain_trace.png
Binary file modified docs/docs/guides/integrations/imgs/litellm_gif.gif
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Binary file modified docs/docs/guides/integrations/imgs/llamaindex_evaluation.png
Binary file modified docs/docs/guides/integrations/imgs/llamaindex_model.png
Binary file modified docs/docs/guides/integrations/imgs/llamaindex_rag.png
Binary file modified docs/docs/guides/integrations/imgs/mistral_model.png
Binary file modified docs/docs/guides/integrations/imgs/mistral_ops.png
Binary file modified docs/docs/guides/integrations/imgs/mistral_trace.png
Binary file modified docs/docs/guides/integrations/imgs/notdiamond/api-keys.png
Binary file modified docs/docs/guides/integrations/imgs/notdiamond/evaluations.png
Binary file modified docs/docs/guides/integrations/imgs/openai-model.png
Binary file modified docs/docs/guides/integrations/imgs/openai-pokedex.png
Binary file modified docs/docs/guides/integrations/imgs/openai.png
Binary file modified docs/docs/guides/integrations/imgs/simple_llamaindex.png
Binary file modified docs/docs/guides/tracking/imgs/feedback_call_header.png
Binary file modified docs/docs/guides/tracking/imgs/feedback_calls.png
Binary file modified docs/docs/guides/tracking/imgs/feedback_tab.png
Binary file modified docs/docs/guides/tracking/imgs/feedback_use.png
Binary file modified docs/docs/media/codegen/codegen_trace.png
Binary file modified docs/docs/media/codegen/eval_dash.png
Binary file modified docs/docs/media/codegen/eval_trace.png
Binary file modified docs/docs/media/dspy_optimization/1.png
Binary file modified docs/docs/media/dspy_optimization/2.png
Binary file modified docs/docs/media/dspy_optimization/3.png
Binary file modified docs/docs/media/dspy_optimization/4.png
Binary file modified docs/docs/media/dspy_optimization/5.png
Binary file modified docs/docs/media/intro/1.png
Binary file modified docs/docs/media/intro/10.png
Binary file modified docs/docs/media/intro/2.png
Binary file modified docs/docs/media/intro/3.png
Binary file modified docs/docs/media/intro/4.png
Binary file modified docs/docs/media/intro/5.png
Binary file modified docs/docs/media/intro/6.png
Binary file modified docs/docs/media/intro/7.png
Binary file modified docs/docs/media/intro/8.png
Binary file modified docs/docs/media/intro/9.png
Binary file modified docs/docs/media/multi-agent-structured-output/0.png
Binary file modified docs/docs/media/multi-agent-structured-output/1.png
Binary file modified docs/docs/media/multi-agent-structured-output/2.png
Binary file modified docs/docs/media/multi-agent-structured-output/3.png
Binary file modified docs/docs/media/pii/encrypt.png
Binary file modified docs/docs/media/pii/redact.png
Binary file modified docs/docs/media/pii/replace.png
Binary file modified docs/docs/media/summarization/dataset.png
Binary file modified docs/docs/media/summarization/eval_dash.png
Binary file modified docs/docs/media/summarization/model.png
Binary file modified docs/docs/media/summarization/summarization_trace.png
Binary file modified docs/static/img/call_edit_screenshot.png
Binary file modified docs/static/img/docusaurus-social-card.jpg
Binary file modified docs/static/img/docusaurus.png
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Binary file modified docs/static/img/evals-hero.png
Binary file modified docs/static/img/export_modal.png
Binary file modified docs/static/img/logo-large-padded.png
Binary file modified docs/static/img/logo-large.png
Binary file modified docs/static/img/screenshots/basic_call.png
Binary file modified docs/static/img/screenshots/calls_filter.png
Binary file modified docs/static/img/screenshots/calls_macro.png
Binary file modified docs/static/img/tutorial-model_invoke3.png
Binary file modified docs/static/img/tutorial-model_re-use.png
Binary file modified docs/static/img/tutorial_trace_1.png
Binary file modified docs/static/img/tutorial_tracing_2_call_uri.png
Binary file modified docs/static/img/tutorial_tracing_2_nested_dinos.png
Binary file modified docs/static/img/weave-hero.png
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Binary file modified docs/static/weave-ui-example.jpg
6 changes: 0 additions & 6 deletions scripts/strip_exif.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,8 @@

def strip_exif(image_path: Path) -> bool:
"""Strip EXIF data from an image file if present.

Args:
image_path: Path to the image file

Returns:
bool: True if successful, False if failed
"""
Expand All @@ -21,10 +19,6 @@ def strip_exif(image_path: Path) -> bool:
if not img.getexif():
return True

# Convert RGBA to RGB if needed (some formats don't support RGBA)
if img.mode == "RGBA":
img = img.convert("RGB")

# Create a new image without EXIF
data = list(img.getdata())
img_without_exif = Image.new(img.mode, img.size)
Expand Down
Binary file modified sdks/node/logs.png
Binary file modified weave_query/testdata/spring-lamb.jpg
Loading