feat(weave): Add mods page and menu item only for wandb admins #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=27a4d98cf35bf1831e2712f6fbbf8b3d303d5fea |
tssweeney
reviewed
Dec 18, 2024
| const mods: ModCategories = { | ||
| Labeling: [ | ||
| { | ||
| id: 'labeling/html', |
There was a problem hiding this comment.
seems odd to have a slash in the id
There was a problem hiding this comment.
Good eye, it is indeed odd but I did this on purpose although we may want to just not allow it. The thinking was all of these mods will be in a git repo somewhere and organizing them in folders would be ideal. I think I can get around this by having the id to directory mapping stored somewhere else...
tssweeney
approved these changes
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new Mods page that we only expose in the overflow menu for wandb admins. It depends on a number of changes in core. I'll be breaking those changes out into seperate PR's with graphite and will link any dependent PR's here.
Testing
How was this PR tested?