chore(app): add endIcon prop to Tag #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=aff47a28a5d3b44cfd112887e8bf5713ec510135 |
ssisk
approved these changes
Dec 18, 2024
gtarpenning
approved these changes
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an
endIconNameprop to the common Tag component so that it can be used for the new Role dropdown designs, where we'd like the dropdown indicator (the chevron) to be inside the Tag boundary like so:Figma here: https://www.figma.com/design/JqVarIxY1vfMLT6RJGpFOn/Art%2FReg%2FAut?node-id=2708-101676&t=l7orWsQNuMiZRioM-4
I don't think
RemovableTagneeds to be updated since the endIcon will most likely not be required with theremoveicon next to it.Testing
Tested in an fe PR that's using this component: https://github.com/wandb/core/pull/25669
